commit 19540a741e79f548bd2846b12c97a52552a27b93
parent 9524c5fcf9c8635eaed05371621250e95c86fa17
Author: Amin Mesbah <dev@aminmesbah.com>
Date: Tue, 2 Apr 2019 20:57:28 -0700
Don't heap allocate because there is no need
Diffstat:
1 file changed, 3 insertions(+), 11 deletions(-)
diff --git a/src/shader.c b/src/shader.c
@@ -144,17 +144,9 @@ void shader_setm4(struct Shader *s, char *name, m4 *mat)
{
if (s)
{
- f32* valueptr = malloc(sizeof(m4));
- if (valueptr)
- {
- glmth_m4_valueptr(*mat, valueptr);
- glUniformMatrix4fv(glGetUniformLocation(s->program, name), 1, GL_TRUE, valueptr);
- free(valueptr);
- }
- else
- {
- printf("Error: Allocation failed\n");
- }
+ f32 valueptr[sizeof(m4)];
+ glmth_m4_valueptr(*mat, valueptr);
+ glUniformMatrix4fv(glGetUniformLocation(s->program, name), 1, GL_TRUE, valueptr);
}
else
{